Re: Booting an alternative kernel from loader prompt fails the first time only

From: Andrey V. Elsukov <ae_at_FreeBSD.org>
Date: Sun, 21 Apr 2013 13:11:09 +0400
On 21.04.2013 04:36, Steven Hartland wrote:
> This fails and trips the "Restart from the beginning" case which contains:
>   last_file_format = i = 0;
>   fp = NULL;
>   continue;
> 
> So "i" gets set to 0 but the loop then increments it to 1 before running
> the next iteration, so its impossible to use first handler in the retry
> case; which I suspect is the kernel loader.
> 
> This also explains why the second call to boot works as last_file_format
> is now 0 due to the previous failure.
> 
> If this is the issue the attached patch should fix it. I can't test it
> ATM as my current box is at the office and doesn't have remote KVM, so
> I need to be in front of it.
> 
> If anyone can confirm this attached patch fixes the problem then I'll get
> it committed, otherwise I'll test on Monday.

Hi,

yes, you are right. I just committed this with r249719.
Thanks.

-- 
WBR, Andrey V. Elsukov
Received on Sun Apr 21 2013 - 07:13:18 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:36 UTC