Re: Linux epoll(7) patch

On Mon, Aug 05, 2013 at 05:25:56PM +0200, Roman Divacky wrote:
> On Mon, Aug 05, 2013 at 08:22:05AM -0700, Alfred Perlstein wrote:
> > On 8/5/13 2:36 AM, Yuri wrote:
> > > There is the patch, suggested by Roman Divacky, implementing Linux 
> > > epoll(7) functionality: 
> > > http://rys.vlakno.cz/~rdivacky/patches/linux_epoll.patch
> > >
> > > This patch was suggested 5 years ago and was discussed on emulation_at_:
> > > http://lists.freebsd.org/pipermail/freebsd-emulation/2008-March/004409.html 
> > >
> > > http://lists.freebsd.org/pipermail/freebsd-emulation/2008-March/004428.html 
> > >
> > >
> > > Discussion stalled back then, and epoll is still unimplemented.
> > >
> > > Anybody can identify any issues with this patch?
> > > Are there any alternatives?
> > >
> > > Yuri
> > The patch is small.  I too am wondering why it's not committed, was 
> > there any push back?
> 
> iirc the main problem with the patch is that it doesnt work over fork, I never
> got to implement that feature.
> 
> Nevertheless it looks like the patch is useful even without that feature so 
> maybe it should just be commited?
> 

What happens to fd after the fork? Is it closed or simply remains
non-functional?

If the former, I suggest the patch is altered to leave fd with badfdops
in place so that epoll users get less surprised.

-- 
Mateusz Guzik <mjguzik gmail.com>