Re: nanobsd-built system doesn't have SVN revision in "uname" (and it looks like regression)

From: Glen Barber <gjb_at_FreeBSD.org>
Date: Sat, 10 Aug 2013 14:24:59 -0400
On Sat, Aug 10, 2013 at 02:11:52PM -0400, Glen Barber wrote:
> On Sat, Aug 10, 2013 at 01:09:20PM -0500, Dan Mack wrote:
> > It looks like you are doing the first [! -z '"${svnversion}"' ]
> > before $svnversion is being set.   In the old version, this was
> > being set via:
> > 
> > if [ -x /usr/bin/svnliteversion ] ; then
> >         svnversion=/usr/bin/svnliteversion
> > fi
> > 
> > But I'm not sure if that's intentional or not ...
> > 
> 
> Ugh.  No, this was not intentional.  I'll have this fixed shortly.
> 

Fixed in r254184.  The problem is that I was evaluating ${svnversion}
being set before looking for /usr/bin/svnliteversion; however when
_running_ /usr/bin/svnliteversion, it was being run as
/usr/bin/svnversion by mistake.

Thank you for the reports, and Dan, thank you for your help.

Glen


Received on Sat Aug 10 2013 - 16:25:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:40 UTC