Re: Further mbuf adjustments and changes

From: Julian Elischer <julian_at_freebsd.org>
Date: Wed, 21 Aug 2013 22:11:10 +0800
On 8/21/13 9:40 PM, Andre Oppermann wrote:
> [ actual text removed.. ]

> Patch is available here:
>
>  http://people.freebsd.org/~andre/mbuf-adjustments-20130821.diff

one small thing I noticed..

-		u16 type = (CSUM_DATA_VALID | CSUM_PSEUDO_HDR);
+		u64 type = (CSUM_DATA_VALID | CSUM_PSEUDO_HDR);
  #if __FreeBSD_version >= 800000


if we are (in ixgbe) supporting different versions then your chang 
eneeds to be enclosed in a
    #if __FreeBSD_version >= 100000000
section

does anyone have a copy of jeff's old mbuf rewrite from a couple of 
years ago?
Have you looked at it? is there overlap?

I'm not sure that we have much of a gain any more by having mbufs with 
built in storage, except to complicate the code.   we could just have 
small external storage types so tha tthe mbuf itself was always 
'external'..
Received on Wed Aug 21 2013 - 12:11:20 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:40 UTC