Re: [PATCH v7 15/19] xen: create a Xen nexus to use in PV/PVH

From: John Baldwin <jhb_at_freebsd.org>
Date: Tue, 24 Dec 2013 10:39:30 -0500
On Thursday, December 19, 2013 1:54:52 pm Roger Pau Monne wrote:
> Introduce a Xen specific nexus that is going to be in charge for
> attaching Xen specific devices. Remove the identify routine from Xen
> devices and instead attach them from the nexus (PV/PVH) or xenpci
> (HVM).

As with my previous mail, I would encourage you to create a xenpv0 device and 
have the xen nexus be very minimal.  This would let you leave the existing 
identify routines in place (which is cleaner / more extensible than a static 
table of devices that you explicitly add), but by having the PV-specific 
drivers attach as children of xenpv0, their identify routines would only be 
invoked when xenpv0 attached.  You can even use an identify routine for CPUs 
(see cpu_identify in sys/x86/x86/legacy.c).

-- 
John Baldwin
Received on Tue Dec 24 2013 - 14:51:15 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:45 UTC