Re: scheduler->swapper, SI_SUB_RUN_SCHEDULER->SI_SUB_LAST

on 02/02/2013 16:50 Konstantin Belousov said the following:
> On Sat, Feb 02, 2013 at 01:50:40PM +0200, Andriy Gapon wrote:
>>
>> I would like to propose the following mostly cosmetic change:
>> http://people.freebsd.org/~avg/scheduler-swapper.diff
>>
>> This is something that bit me early in my FreeBSD days, so I am kind of obsessed
>> with it.
>> The current naming is confusing/misleading indeed.
>> And magic properties of SI_SUB_RUN_SCHEDULER:SI_ORDER_LAST is a "hidden gem".
> 
> You may remove the Giant unlock from the scheduler()/swapper() as well
> then, doing it before the swapper() call in the mi_startup().
> 
> Note that the wait chain for the idle swapper is still called "sched".

Thank you for the review.  I am fixing both issues.

-- 
Andriy Gapon