Re: [PATCH] Variable-size ioctl data handling

From: John Baldwin <jhb_at_freebsd.org>
Date: Tue, 22 Jan 2013 13:54:45 -0500
On Monday, January 21, 2013 3:26:21 pm Yuri wrote:
> Hi,
> 
> Could anybody please review and check in the patch 
> patch-ioctl-var-size.txt from this PR: 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=175425 ?
> This patch introduces the generic way to pass variable size ioctl 
> argument using the structure like this struct my_struct {int len; ...any 
> fields...}.

I think this layout is a bit of a special case.  I think you should just put 
the userland pointer in length in the structure you pass to the ioctl as mdf_at_ 
suggested in the thread on hackers_at_.  If nothing else, the length should be a 
size_t instead of an int.

-- 
John Baldwin
Received on Tue Jan 22 2013 - 19:11:04 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:34 UTC