Re: hwpmc support for Ivy Bridge Xeon

On Sat, Jan 26, 2013 at 1:58 AM, hiren panchasara
<hiren.panchasara_at_gmail.com> wrote:
> I've tried to update hwpmc by adding support for xeon class of Ivy
> bridge processors.
>
> Thanks Jim for pointing me to the correct document. (325462-045US Jan 2013)
>
> I do not have a reference machine to test with. Any help in that
> regard would be appreciated.
>
> Here are the diffs against head (245927):
> http://www.strugglingcoder.info/patches/hwpmc_ibx.txt
>
> Thanks,
> Hiren
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"

>From a first look appears good -- I've a couple of observations though.
I see your patch covers only core events -- am I missing something?

Not really important, and I don't want to be pedantic here, but maybe
this can be renamed to something less ugly:

 static int
-iap_event_sb_sbx_ib_ok_on_counter(enum pmc_event pe, int ri)
+iap_event_sb_sbx_ib_ibx_ok_on_counter(enum pmc_event pe, int ri)


-- 
Davide