Re: [head tinderbox] failure on sparc64/sparc64

From: John Baldwin <jhb_at_freebsd.org>
Date: Thu, 11 Jul 2013 09:56:11 -0400
On Thursday, July 11, 2013 3:07:33 am Adrian Chadd wrote:
> On 11 July 2013 00:05, Navdeep Parhar <nparhar_at_gmail.com> wrote:
> > On Wed, Jul 10, 2013 at 10:38:47PM -0700, Adrian Chadd wrote:
> >> I don't get why this is dying. any ideas?
> >
> > Maybe because sparc64's ucontext.h is getting pulled in, and it has
> > this:
> >
> > #define mc_flags        mc_global[0]
> 
> Ugh, we should fix this. When did this happen?

annotate is your friend.  It's over 10 years old:

Working file: /home/jhb/work/freebsd/svn/head/sys/sparc64/include/ucontext.h
------------------------------------------------------------------------
r105733 | jake | 2002-10-22 14:03:15 -0400 (Tue, 22 Oct 2002) | 13 lines

- Expand struct trapframe to 256 bytes, make all fields fixed width and the
  same size.  Add some fields that previously overlapped with something else
  or were missing.
- Make struct regs and struct mcontext (minus floating point) the same as
  struct trapframe so converting between them is easy (null).
- Add space for saving floating point state to struct mcontext.  This requires
  that it be 64 byte aligned.
- Add assertions that none of these structures change size, as they are part
  of the ABI.
- Remove some dead code in sendsig().
- Save and restore %gsr in struct trapframe.  Remember to restore %fsr.
- Add some comments to exception.S.

------------------------------------------------------------------------

-- 
John Baldwin
Received on Thu Jul 11 2013 - 15:41:21 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:39 UTC