Re: r248583 Kernel panic: negative refcount 0xfffffe0031b59168

From: Eugene M. Zheganin <emz_at_norma.perm.ru>
Date: Mon, 15 Jul 2013 15:16:37 +0600
Hi.

On 02.07.2013 05:10, Pawel Jakub Dawidek wrote:
> On Sun, Jun 30, 2013 at 01:18:36PM +0200, Mateusz Guzik wrote:
>>
>> Turns out the bug is quite funny ;)
>>
>> Try this:
>> diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c
>> index 5d8e814..7a4db04 100644
>> --- a/sys/kern/uipc_usrreq.c
>> +++ b/sys/kern/uipc_usrreq.c
>> _at__at_ -1764,8 +1764,8 _at__at_ unp_externalize(struct mbuf *control, struct mbuf **controlp, int flags)
>>  			}
>>  			for (i = 0; i < newfds; i++, fdp++) {
>>  				fde = &fdesc->fd_ofiles[*fdp];
>> -				fde->fde_file = fdep[0]->fde_file;
>> -				filecaps_move(&fdep[0]->fde_caps,
>> +				fde->fde_file = fdep[i]->fde_file;
>> +				filecaps_move(&fdep[i]->fde_caps,
>>  				    &fde->fde_caps);
>>  				if ((flags & MSG_CMSG_CLOEXEC) != 0)
>>  					fde->fde_flags |= UF_EXCLOSE;
> Thanks for tracking it down before I had time to get to it!
> The change looks good.
>
Guys, if this is working, why it's not commited to HEAD ? I'm still
hitting this bug on r251990 and later ones.

Thanks.
Eugene.
Received on Mon Jul 15 2013 - 07:16:41 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:39 UTC