On 6/19/13, John Marino <dragonflybsd_at_marino.st> wrote: > On 6/19/2013 01:00, Oliver Pinter wrote: >> Hi all! >> >> Attached a fix to gccmakedep. > > > So.... > 1) There's already multiple PRs on this, including one I just submitted: > http://www.freebsd.org/cgi/query-pr.cgi?pr=179571 > > 2) Your patch adds an ".endif" which is already there Hmm.. now I checked in github too: https://github.com/freebsd/freebsd-ports/blob/master/devel/gccmakedep/Makefile . Sure. Then my local git repo was broken. > > 3) Is not it better to submit via PR (GNATS) rather than a mailing list? > That's what PRs are for... Mail are faster than PR-s. > > John > >Received on Tue Jun 18 2013 - 21:51:42 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:38 UTC