Re: [head tinderbox] failure on arm/arm

On 2013-06-19 07:27, Tim Kientzle wrote:>>>>> stage 4.2: building libraries
>>>>> stage 4.3: make dependencies
>>>>> stage 4.4: building everything
>> [...]
>> /src/usr.bin/svn/lib/libapr/../../../../contrib/apr/include/apr_ring.h:183:34: note: expanded from macro 'APR_RING_PREV'
>> #define APR_RING_PREV(ep, link) (ep)->link.prev
>>                                 ^
>> /src/usr.bin/svn/lib/libapr/../../../../contrib/apr/include/apr_ring.h:177:34: note: expanded from macro 'APR_RING_NEXT'
>> #define APR_RING_NEXT(ep, link) (ep)->link.next
>>                                 ^
>> fatal error: too many errors emitted, stopping now [-ferror-limit=]
>> 1 warning and 20 errors generated.
>> *** Error code 1
>>
>> Stop.
>> make: stopped in /src/usr.bin/svn/lib/libapr
>> *** Error code 1
> 
> This might be the OffsetOf bug for APR on ARM.
> We just got a fix pushed upstream for this a few
> days ago.
> 
> I don't have time to look, but someone should take
> a peek at the following patch and see if it's
> needed:
> 
> --- ./apr-1.4.7/include/apr_general.h.orig
> +++ ./apr-1.4.7/include/apr_general.h
> _at__at_ -76,7 +76,7 _at__at_
> ·*·_at_return·offset
> ·*/
> -#if·defined(CRAY)·||·(defined(__arm)·&&·!defined(LINUX))
> +#if·defined(CRAY)·||·(defined(__arm)·&&·!(defined(LINUX)·||·defined(__FreeBSD__)))
> #ifdef·__STDC__
> #define·APR_OFFSET(p_type,field)·_Offsetof(p_type,field)
> #else
> 

Sorry for the late reply,

There is a new apr version on the way which contains the fix already,
I suspect it will be released during the next days (if no show stopper is found)

The following patch updates apr from 1.4.6 to 1.4.8
 http://people.freebsd.org/~ohauer/diffs/apr-1.4.8.1.4.1.diff

Would you mind to test the new version on the arm platform and run
$> make test (as non priv. user)

I have tested on 8.4 and 9.1 no 10-cur system available,
tests do not run on redports because of system restrictions (jail).

--
olli