Re: RFC: swapon(8) vnode-backed md and gbde/geli encryption support

Scot Hetzel <swhetzel_at_gmail.com> wrote
  in <CACdU+f-OuPNckG+MJgfDopbT43xMrLy19LmEzLqgZ_XU9yYX7Q_at_mail.gmail.com>:

sw> The only thing I see is that you are hard coding the geli_swap_flags
sw> (i.e. -e aes -l 256 -s 4096 -d) into swapon.  It would be better to
sw> have swapon read the /etc/fstab file to get these values:
sw>
sw> /dev/ada1p2.eli        none    swap
sw> sw,ealgo=aes,keylen=256,sectorsize=4096              0 0
sw> /dev/ada2p2.eli        none    swap    sw              0 0
sw>
sw> What you could do is that if no options are specified in the swap
sw> file, swapon would then use default values for ealgo=aes, keylen=256
sw> and sectorsize=4096.

 Thank you for your feedback.  These options are implemented in the
 attached patch.

-- Hiroki