Re: r247835: drm2 code breaks buildkernel

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Tue, 5 Mar 2013 20:15:38 +0200
On Tue, Mar 05, 2013 at 05:40:34PM +0100, Jean-S?bastien P?dron wrote:
> On 05.03.2013 16:37, Konstantin Belousov wrote:
> > The patch below is supposed to fix double declaration (it is pathetic that
> > clang silently accepts this, while issuing countless useless warnings).
> > Also there is a usual workaround for the anonimous union/struct issue.
> 
> What do you think about "-fms-extensions"? It avoids modifications to
> the code and works with both gcc and clang.
Since TTM code needs a lot of modifications anyway, I do not mind to
make one more local change. I already did it, please see r247849.
This is IMO better then getting more unhandled warnings.

> 
> There're several unnamed structs/unions in the radeon code too. I would
> like to keep the diff with Linux code as small as possible.

It is your call. I am only looking after the TTM right now.

Received on Tue Mar 05 2013 - 17:15:44 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:35 UTC