panic: pfsync_insert_state: st->sync_state == PFSYNC_S_NONE

Hi

We just experienced the following panic on r249172

It was coincident with a panic on our other router using carp+pfsync.

Unread portion of the kernel message buffer:
panic: pfsync_insert_state: st->sync_state == PFSYNC_S_NONE
cpuid = 12
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2a/frame 0xffffff846b3c2950
vpanic() at vpanic+0xe9/frame 0xffffff846b3c2990
kassert_panic() at kassert_panic+0xd5/frame 0xffffff846b3c2a80
pfsync_insert_state() at pfsync_insert_state+0x10c/frame 0xffffff846b3c2ab0
pf_state_insert() at pf_state_insert+0x86a/frame 0xffffff846b3c2b30
pf_test_rule() at pf_test_rule+0x11a2/frame 0xffffff846b3c3040
pf_test() at pf_test+0x2216/frame 0xffffff846b3c3730
pf_check_in() at pf_check_in+0x27/frame 0xffffff846b3c3750
pfil_run_hooks() at pfil_run_hooks+0xd7/frame 0xffffff846b3c37f0
ip_input() at ip_input+0x2b7/frame 0xffffff846b3c3840
netisr_dispatch_src() at netisr_dispatch_src+0x153/frame 0xffffff846b3c38b0
ether_demux() at ether_demux+0x1c0/frame 0xffffff846b3c38e0
ether_nh_input() at ether_nh_input+0x277/frame 0xffffff846b3c3920
netisr_dispatch_src() at netisr_dispatch_src+0x153/frame 0xffffff846b3c3990
ether_demux() at ether_demux+0x83/frame 0xffffff846b3c39c0
ether_nh_input() at ether_nh_input+0x277/frame 0xffffff846b3c3a00
netisr_dispatch_src() at netisr_dispatch_src+0x153/frame 0xffffff846b3c3a70
igb_rxeof() at igb_rxeof+0x394/frame 0xffffff846b3c3ae0
igb_msix_que() at igb_msix_que+0xe9/frame 0xffffff846b3c3b20
intr_event_execute_handlers() at intr_event_execute_handlers+0x6a/frame 0xffffff846b3c3b50
ithread_loop() at ithread_loop+0x99/frame 0xffffff846b3c3ba0
fork_exit() at fork_exit+0x139/frame 0xffffff846b3c3bf0
fork_trampoline() at fork_trampoline+0xe/frame 0xffffff846b3c3bf0
--- trap 0, rip = 0, rsp = 0xffffff846b3c3cb0, rbp = 0 ---

#0  doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:264
264             if (textdump && textdump_pending) {
(kgdb) #0  doadump (textdump=1) at /usr/src/sys/kern/kern_shutdown.c:264
#1  0xffffffff80450076 in kern_reboot (howto=260)
    at /usr/src/sys/kern/kern_shutdown.c:447
#2  0xffffffff80450583 in vpanic (fmt=<value optimized out>, 
    ap=<value optimized out>) at /usr/src/sys/kern/kern_shutdown.c:754
#3  0xffffffff80450775 in kassert_panic (
    fmt=0xffffffff806cb190 "%s: st->sync_state == PFSYNC_S_NONE")
    at /usr/src/sys/kern/kern_shutdown.c:642
#4  0xffffffff8056573c in pfsync_insert_state (st=0xfffffe02adb98128)
    at /usr/src/sys/netpfil/pf/if_pfsync.c:1645
#5  0xffffffff8056b6ba in pf_state_insert (kif=<value optimized out>, 
    skw=0x0, sks=0xfffffe02c8caf688, s=0xfffffe02adb98128)
    at /usr/src/sys/netpfil/pf/pf.c:1120
#6  0xffffffff8056ce32 in pf_test_rule (rm=0xffffff846b3c3690, 
    sm=0xffffff846b3c3688, direction=1, kif=0xfffffe0030dbd800, 
    m=0xfffffe0205416400, off=20, pd=0xffffff846b3c34c0, 
    am=0xffffff846b3c3698, rsm=0xffffff846b3c3680, inp=0x0)
    at /usr/src/sys/netpfil/pf/pf.c:3513
#7  0xffffffff80570196 in pf_test (dir=1, ifp=<value optimized out>, 
    m0=0xffffff846b3c37b8, inp=0x0) at /usr/src/sys/netpfil/pf/pf.c:5772
#8  0xffffffff80575d07 in pf_check_in (arg=<value optimized out>, 
    m=0xffffff846b3c37b8, ifp=<value optimized out>, 
    dir=<value optimized out>, inp=<value optimized out>)
    at /usr/src/sys/netpfil/pf/pf_ioctl.c:3478
#9  0xffffffff805268a7 in pfil_run_hooks (ph=0xffffffff809f2fc0, 
    mp=0xffffff846b3c3810, ifp=0xfffffe0030f47800, dir=1, inp=0x0)
    at /usr/src/sys/net/pfil.c:84
#10 0xffffffff80547717 in ip_input (m=0xfffffe0205416400)
    at /usr/src/sys/netinet/ip_input.c:503
#11 0xffffffff80525853 in netisr_dispatch_src (proto=1, source=0, 
    m=<value optimized out>) at /usr/src/sys/net/netisr.c:1013
#12 0xffffffff8051a9a0 in ether_demux (ifp=0xfffffe0030f47800, 
    m=0xfffffe0205416400) at /usr/src/sys/net/if_ethersubr.c:851
#13 0xffffffff8051acd7 in ether_nh_input (m=<value optimized out>)
    at /usr/src/sys/net/if_ethersubr.c:646
#14 0xffffffff80525853 in netisr_dispatch_src (proto=9, source=0, 
    m=<value optimized out>) at /usr/src/sys/net/netisr.c:1013
#15 0xffffffff8051a863 in ether_demux (ifp=0xfffffe0030968000, 
    m=0xfffffe0205416400) at /usr/src/sys/net/if_ethersubr.c:760
#16 0xffffffff8051acd7 in ether_nh_input (m=<value optimized out>)
    at /usr/src/sys/net/if_ethersubr.c:646
#17 0xffffffff80525853 in netisr_dispatch_src (proto=9, source=0, 
    m=<value optimized out>) at /usr/src/sys/net/netisr.c:1013
#18 0xffffffff80301294 in igb_rxeof (que=0xfffffe0030819a00, count=499, 
    done=0x0) at /usr/src/sys/dev/e1000/if_igb.c:4732
#19 0xffffffff803016a9 in igb_msix_que (arg=<value optimized out>)
    at /usr/src/sys/dev/e1000/if_igb.c:1590
#20 0xffffffff80425d2a in intr_event_execute_handlers (
    p=<value optimized out>, ie=0xfffffe0030883500)
    at /usr/src/sys/kern/kern_intr.c:1263
#21 0xffffffff804273c9 in ithread_loop (arg=0xfffffe003088f0e0)
    at /usr/src/sys/kern/kern_intr.c:1276
#22 0xffffffff804230f9 in fork_exit (
    callout=0xffffffff80427330 <ithread_loop>, arg=0xfffffe003088f0e0, 
    frame=0xffffff846b3c3c00) at /usr/src/sys/kern/kern_fork.c:991
#23 0xffffffff805ff39e in fork_trampoline ()
    at /usr/src/sys/amd64/amd64/exception.S:602
#24 0x0000000000000000 in ?? ()

Ian

-- 
Ian Freislich