Re: openjdk6 broken on current

On Wed, May 08, 2013 at 11:52:24AM -0500, Larry Rosenman wrote:
> ...
> >Did/can you try just backing out r249606?
> ...
> How can I generate a patch to do that? 
> ...

(Note that /S4/usr/src is where my "head" sources are on this machine at
present.)

d129(9.1-S)[5] cd /S4/usr/src
d129(9.1-S)[6] svn diff -c -249606
Index: lib/libthr/thread/thr_sig.c
===================================================================
--- lib/libthr/thread/thr_sig.c (revision 249606)
+++ lib/libthr/thread/thr_sig.c (revision 249605)
_at__at_ -732,12 +732,8 _at__at_
 {
        ucontext_t uc;
 
-       if (ucp == NULL)
-               return (EINVAL);
-       if (!SIGISMEMBER(uc.uc_sigmask, SIGCANCEL))
-               return __sys_setcontext(ucp);
        (void) memcpy(&uc, ucp, sizeof(uc));
-       SIGDELSET(uc.uc_sigmask, SIGCANCEL);
+       remove_thr_signals(&uc.uc_sigmask);
        return __sys_setcontext(&uc);
 }
 
_at__at_ -747,13 +743,7 _at__at_
 {
        ucontext_t uc;
 
-       if (oucp == NULL || ucp == NULL)
-               return (EINVAL);
-       if (SIGISMEMBER(ucp->uc_sigmask, SIGCANCEL)) {
-               stdout_debug("remove SIGCANCEL\n");     
-               (void) memcpy(&uc, ucp, sizeof(uc));
-               SIGDELSET(uc.uc_sigmask, SIGCANCEL);
-               ucp = &uc;
-       }
-       return __sys_swapcontext(oucp, ucp);
+       (void) memcpy(&uc, ucp, sizeof(uc));
+       remove_thr_signals(&uc.uc_sigmask);
+       return __sys_swapcontext(oucp, &uc);
 }
d129(9.1-S)[7] 

In practice, I would have saved that to a file, then fed it to "svn patch".

Peace,
david
-- 
David H. Wolfskill				david_at_catwhisker.org
Taliban: Evil men with guns afraid of truth from a 14-year old girl.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.