Hi, current! I received a positive feedback from Grzegorz Bernacki (semihalf). He said that my patch is ok. Can anyone commit a proposed patch? 2013/5/21 Alexander Fedorov <alexander.fedorov_at_rtlservice.com>: > Hi all! > > I'm writing NAND Flash controller driver for my Hackberry board. > And I found that NAND Framework does not properly detecting ONFI > compiliant chips. > > First, ONFI specification says (p. 40 > http://www.onfi.org/~/media/ONFI/specs/ONFI_1_0_Gold.pdf): > >>The ONFI signature is the ASCII encoding of 'ONFI' where 'O' = 4Fh, 'N' = 4Eh, 'F' = 46h, 'I' = 49h. > > But, current code check it for 'o', 'n', 'f', 'I'. > > Second, function "onfi_read_parameter" (nand_generic.c) read > parameters page using this construction: >>NANDBUS_READ_BUFFER(nandbus, params, sizeof(struct onfi_params)); > > So, structure onfi_params must be declared as packed. > > Proposed patch solves the problem for me. > Is this patch ok?
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:38 UTC