Re: [head tinderbox] failure on mips/mips

On 08 Nov 2013, at 16:08, Adrian Chadd <adrian_at_freebsd.org> wrote:
> On 8 November 2013 02:32, FreeBSD Tinderbox <tinderbox_at_freebsd.org> wrote:
> 
> [snip]
> 
>> cc  -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option   -nostdinc  -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 --param max-inline-insns-single=1000  -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror  /src/sys/contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c -I/src/sys/dev/ath -I/src/sys/dev/ath/ath_hal -I/src/sys/contrib/dev/ath/ath_hal
>> cc1: warnings being treated as errors
>> /src/sys/contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c: In function 'ar9300_chip_reset':
>> /src/sys/contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:1337: warning: inlining failed in call to 'ar9300_init_pll': --param max-inline-insns-single limit reached [-Winline]
>> /src/sys/contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:2011: warning: called from here [-Winline]
>> *** Error code 1
> 
> ?!?!?!??!

Apparently gcc cannot inline this function, with the current inlining
limits.  Maybe the inline should be dropped, if the function is that
large.... :-)

-Dimitry