Re: [PATCH] Haswell Kernel Mode Setting

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Tue, 12 Nov 2013 10:29:32 +0200
On Mon, Nov 11, 2013 at 03:39:06PM -0800, Xin Li wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On 11/11/13 14:29, Neel Chauhan wrote:
> > Sorry if I sent a similar patch before. It didn't get accepted so I
> > am sending one now. Enjoy.
> 
> What does "didn't get accepted" mean? :)  Since this looks like a
> PCI-ID only change that do not affect other existing hardware, if it's
> not an explicit objection from a reviewer, I think it's Okay to just
> go ahead and commit the change after a reasonable timeout instead of
> waiting indefinitely.

I very much doubt that this patch works. More, I believe that it was
not tested at all. Talking about the trivially obvious things, the PGTT
handling must be updated since page tables have different format comparing
with Ivy, there are some changes to ring dispatching, and lot of
changes in the display pipeline. All this is missing from the patch.

Oh, and the Series 8 chipset PCH detection is missing.  I probably
should stop now.

HSW support is much more than just adding the Ids, I am (slowly) starting
the work on importing the Linux updates.

Received on Tue Nov 12 2013 - 07:29:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:44 UTC