Re: ipfw build error with WITHOUT_PF (pfvar.h)

From: Andrey Chernov <ache_at_freebsd.org>
Date: Sat, 23 Nov 2013 12:20:40 +0400
On 23.11.2013 12:12, Gleb Smirnoff wrote:
>   Andrey,
> 
> On Sat, Nov 23, 2013 at 12:07:35PM +0400, Andrey Chernov wrote:
> A> There is a problem in recent -current to build ipfw with WITHOUT_PF
> A> option, introduced in r257215. altq.c file produce error due to included
> A> <net/pfvar.h> have following includes
> A> 
> A> #include <netpfil/pf/pf.h>
> A> #include <netpfil/pf/pf_altq.h>
> A> #include <netpfil/pf/pf_mtag.h>
> A> 
> A> and netpfil/pf directory is empty in
> A> /usr/src/include/Makefile with WITHOUT_PF option.
> 
> The quick solution would be to make ipfw lose some functionality if
> PF is cut away from system.
> 
> The proper solution would be to make ALTQ configurable w/o pfctl.
> 

How it was handled previously? F.e. ipfw in -stable 9 builds normally
with WITHOUT_PF and have pfvar.h included too, but old pfvar.h have only
<net/pf_mtag.h> which is available with WITHOUT_PF.

By a first glance, alternative altq.c file with the same functions
declared, but does nothing will be solution, replacing original when
MK_PF is no.
Received on Sat Nov 23 2013 - 07:20:52 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:44 UTC