Re: [CFT] Patch to bsdinstall to support root-on-ZFS and GELI

On 2013-10-09 03:22, Matthias Gamsjager wrote:
> Hi,
>
> tried 10-8 iso in Virtualbox but after reboot I was looking at a
> bootloader with a nice '-' but nothing more. 
> post setup 'gpart list' showed no entries at all.
>
>
>
>
> On Wed, Oct 9, 2013 at 5:49 AM, Allan Jude <freebsd_at_allanjude.com
> <mailto:freebsd_at_allanjude.com>> wrote:
>
>     On 2013-10-07 15:59, Allan Jude wrote:
>     > Devin Teske and I have been working on a big patch to bsdinstall to
>     > implement installing on a ZFS pool. It supports both GPT and
>     MBR, the 4k
>     > sector gnop trick, and optional GELI encryption. We would like
>     to commit
>     > this in time for 10.0-BETA1 so it needs some testing to work out any
>     > obvious bugs before we send it off to re_at_ to get it committed.
>     >
>     > It includes a single configuration menu that allows you to
>     select all of
>     > the required details, including which drives to use (gets
>     details from
>     > camcontrol, also includes an inspection utility that presents the
>     > detailed output of camcontrol inquiry/identify, and gpart show),
>     what
>     > ZFS RAID level to use (taking in to consideration the selected
>     number of
>     > drives), GPT/mbr, 4k YES/no, GELI yes/NO, pool name, etc.
>     >
>     >
>     > Additional, it includes some other changes to bsdinstall:
>     > 1. Change the default to the 'non-standard keyboard mapping'
>     prompt to no
>     > 2. Replace the 3 separate dialogs to configure an ipv4 address
>     with just 1
>     > 3. Remove the dialog asking if you wish to enable crash dumps, this
>     > feature has been combined into the regular 'services to enable'
>     dialog
>     > and enabled by default
>     >
>     >
>     > You can browse the patches here:
>     > http://druidbsd.cvs.sf.net/viewvc/druidbsd/bsdinstall_zfs/
>     >
>     > I've built a bootonly.iso (10.0-ALPHA4) to make testing easier,
>     > available compressed (48 MB) or uncompressed (211 MB):
>     >
>     > http://www.allanjude.com/bsd/zfsbootonly_2013-10-06.iso.xz
>     >
>     > http://www.allanjude.com/bsd/zfsbootonly_2013-10-06.iso
>     >
>     >
>     > We look forward to your feedback
>     >
>
>     We've made more improvements, including corporating most all of the
>     feedback we've gotten so far
>
>
>     Outstanding items:
>     1. Apply the changes to ipv6 config the way we did ipv4
>     2. improve disk identification (model info and serial # instead of one
>     or the other)
>     3. Include a helpful message before the GELI step where you have to
>     enter your password many times, the user will be less confused if
>     it is
>     explained why they have to enter their password 3 * number of
>     disks times
>     4. Validate vdev type choice inside the vdev type menu, and warn the
>     user if they have made an invalid selection, so they can add more
>     disks
>     or chance their selection, without having to try to start the
>     installation first
>     5. Whatever else you guys find wrong tonight
>
>     I generated new test images, and attached the patch (which got REALLY
>     big when Devin Teske decided to fix "all of the things":
>
>     http://www.allanjude.com/bsd/zfsbootonly.2013-10-08.iso.xz
>
>     http://www.allanjude.com/bsd/zfsbootonly.2013-10-08.iso
>
>
>     --
>     Allan Jude
>
>
>     _______________________________________________
>     freebsd-current_at_freebsd.org <mailto:freebsd-current_at_freebsd.org>
>     mailing list
>     http://lists.freebsd.org/mailman/listinfo/freebsd-current
>     To unsubscribe, send any mail to
>     "freebsd-current-unsubscribe_at_freebsd.org
>     <mailto:freebsd-current-unsubscribe_at_freebsd.org>"
>
>
This was a variable scoping error made by Devin when he refactored some
of the code into a subroutine. I have fixed it

-- 
Allan Jude