On Sat, 2013-10-26 at 20:22 -0400, Eitan Adler wrote: > On Sat, Oct 26, 2013 at 11:04 AM, Sean Bruno <sean_bruno_at_yahoo.com> wrote: > > This adds proper braces to clear Clang warnings about dangling else > > statements in groff. There is no(intended) functional change. > > > For contributed code why not just disable warnings? Fixing code is > good but doing so in our repository instead of upstream doesn't help > as much. > > I believe very strongly that the people who construct compilers know C/C ++ far better than I do, so warnings are their note to me that I'm doing it wrong. Disabling warnings is global for a section of the tree (e.g. groff/roff). I can't (easily) isolate the warnings individually, so modifications to the code after I disable the warnings will get excluded as well, effectively opening the project to crappy code that breaks things (if the warnings are causing bugs). For this specific code (groff), it switched to gpl v3 in 2009, so we won't be doing any more code drops into our tree: Revision 1.5 - (view) (download) (annotate) - [select for diffs] Sun Jan 4 14:50:51 2009 UTC (4 years, 9 months ago) by wl Branch: MAIN Changes since 1.4: +3 -3 lines Diff to previous 1.4 * */*: Update GPL2 to GPL3. Therefore, if someone isn't going to rewrite the implementations, its up to us to maintain the code we have. sean "Warnings are meaningful." FreeBSD Clusteradm/Developer
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:43 UTC