Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0);

On Tue, 10 Sep 2013 00:02:37 +0300
Ivan Klymenko <fidaj_at_ukr.net> wrote:

> В Mon, 9 Sep 2013 22:37:48 +0200
> "O. Hartmann" <ohartman_at_zedat.fu-berlin.de> пишет:
> 
> > x11/nvidia-driver (as well as emulators/virtualbox-ose-kmod) do not
> > compile on  FreeBSD 10.0-CURRENT #0 r255426: Mon Sep  9 21:35:43
> > CEST 2013 amd64.
> > 
> > The error is:
> > 
> > x11/nvidia-driver:
> > 
> > --- nvidia_subr.o ---
> > nvidia_subr.c:835:46: error: too few arguments to function call,
> > expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0);
> >                                              ^
> > _at_/vm/vm_map.h:368:1: note: 'vm_map_find' declared here
> > int vm_map_find(vm_map_t, vm_object_t, vm_ooffset_t, vm_offset_t *,
> > vm_size_t, ^
> > 1 error generated.
> > *** [nvidia_subr.o] Error code 1
> > 
> > 
> > emulators/virtualbox-ose-kmod:
> > 
> > [...]
> >  /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.2.18/out/freebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/alloc-r0drv-freebsd.c:83:76:
> > error: too few arguments to function call, expected 10, have 9
> > cbAllocated, TRUE, VM_PROT_ALL, VM_PROT_ALL, 0); ^
> > _at_/vm/vm_map.h:368:1: note: 'vm_map_find' declared here int
> > vm_map_find(vm_map_t, vm_object_t, vm_ooffset_t, vm_offset_t *,
> > vm_size_t,
> 
> Try the following changes:
>         int rc = vm_map_find(kernel_map, pVmObject, 0, &Addr,
> ---                          cbAllocated, TRUE, VM_PROT_ALL,
> VM_PROT_ALL, 0); +++                          cbAllocated, 0,
> VMFS_OPTIMAL_SPACE, VM_PROT_ALL, VM_PROT_ALL, 0);
> 
> for Nvidia driver need to make similar changes...
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to
> "freebsd-current-unsubscribe_at_freebsd.org"

The man page of vm_map_find() says the last parameter is of int, named
int cow. On the hurry, I didn't find any explanation of that parameter.
Setting it to "0" (zero) also in the nvidia_subr.c makes the driver
compile again.

But simply filling in a int zero is a bit strange without knowing what
to do, isn't it?

Thanks anyway,

Oliver