Re: CURRENT r255426: x11/nvidia-driver: nvidia_subr.c:835:46: error: too few arguments to function call, expected 10, have 9 (VM_PROT_READ | VM_PROT_WRITE), 0);

Hello,


2013/9/10 O. Hartmann <ohartman_at_zedat.fu-berlin.de>

> Yes, you're correct and my face is red like a tomatoe :-(
>
> I try this sed replacement expression:
> sed -i -e '/\&virtual_address\, size\, \
> VMFS_ANY\_SPACE\,$/s//\&virtual_address\, size\, 0\, \
> VMFS_ANY\_SPACE\,/g' work/NVIDIA-FreeBSD-x86_64-325.15/src/nvidia_subr.c
>
> It works from the command line, but it doesn't work from the (attached)
> Makefile-patch.
>


A little bit late here (I see a patch has been commited to
x11/nvidia-driver/Makefile, with a shorter sed expression) but your
problems seems to come from make interpreting "$".
The "$/" variable is null, it's stripped from the sed expression which
becomes invalid.
You should escape the "$" inside the sed expression by doubling it.

Cheers

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier_at_gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."