Re: ipmi patch for review

From: Gleb Smirnoff <glebius_at_FreeBSD.org>
Date: Fri, 20 Sep 2013 09:44:52 +0400
  John,

On Thu, Sep 19, 2013 at 03:04:46PM -0400, John Baldwin wrote:
J> >   When system is writing a kernel core dump, it issues watchdog
J> > pat wdog_kern_pat(WD_LASTVAL). If ipmi is in action, it registers
J> > ipmi_wd_event() as event for watchdog. Thus ipmi_wd_event() is
J> > called in dumping context.
J> > 
J> > The problem is that ipmi_wd_event() calls into ipmi_set_watchdog(),
J> > that calls into ipmi_alloc_request(), which uses M_WAITOK and
J> > thus sleeps. This is a smaller problem, since can be converted to
J> > M_NOWAIT. But ipmi_set_watchdog() then calls into
J> > ipmi_submit_driver_request(), which calls msleep() any time.
J> > 
J> >   The attached patch allows me to successfully write cores in
J> > presence of IPMI.
J> 
J> Of course, the watchdog might go off during your dump. :)

Yes, I understand that :(

But, imho patch improves situation, although is ugly.

J> The real fix is more complicated, which is that we should not use
J> a worker thread for at least SMIC and KCS.

-- 
Totus tuus, Glebius.
Received on Fri Sep 20 2013 - 03:45:10 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:41 UTC