Re: loader lszfs command

On Thu, 7 Aug 2014 14:17-0700, dteske_at_FreeBSD.org wrote:

> Hi,
> 
> People have been pestering me to update the Forth code to present
> a menu of ZFS datasets (*cough* boot environments *cough*).
> 
> Would love to, but existing code seems broken.
> 
> Can *anybody* produce meaningful output from the following?
> 
> http://svnweb.freebsd.org/base?view=revision&revision=241284
> 
> All I get on every system I've tried (multiple versions, including HEAD)
> produce the following:
> 
>  OK lszfs zroot
> ZFS: i/o error - all block copies unavailable
> operation not permitted
> 
> It's really hard for me to start with something that's broken. Can
> I get confirmation that this doesn't appear to be working as intended?
> If so, I'll go ahead and try to fix it, but need to confirm that I'm ( a )
> not
> crazy and ( b ) seeing the same thing everybody else is seeing.

A bit on the side, but more user friendly:

You should change the error message on line 335 to explain how to use 
lszfs, or add a "help lszfs" command.

Instead of merely complaining about "wrong number of arguments", how 
about stating something like "wrong number of arguments, need at least 
pool name"?

-- 
+-------------------------------+------------------------------------+
| Vennlig hilsen,               | Best regards,                      |
| Trond Endrestøl,              | Trond Endrestøl,                   |
| IT-ansvarlig,                 | System administrator,              |
| Fagskolen Innlandet,          | Gjøvik Technical College, Norway,  |
| tlf. mob.   952 62 567,       | Cellular...: +47 952 62 567,       |
| sentralbord 61 14 54 00.      | Switchboard: +47 61 14 54 00.      |
+-------------------------------+------------------------------------+