Re: Buildworld fails due to WITHOUT_CRYPT (3 issues)

On Dec 24, 2014, at 1:45, Beeblebrox <zaphod_at_berentweb.com> wrote:

> I plan on using openssl from ports and have no need for kerberos.
> /etc/src.conf >> WITHOUT_CRYPT= yes
> 
> * First problem is with bsnmp (used WITHOUT_BSNMP to bypass)
> ===> lib/libbsnmp/libbsnmp (all)
> cc   -O2 -pipe   -I/asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib -DHAVE_ERR_H -DHAVE_GETADDRINFO -DHAVE_STRLCPY -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DQUADFMT='"llu"' -DQUADXFMT='"llx"' -DNDEBUG -std=gnu99 -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c -o snmpcrypto.o
> /asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:370:1: error: 
>      conflicting types for 'snmp_passwd_to_keys'
> snmp_passwd_to_keys(struct snmp_user *user, char *passwd __unused)
> /asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:273:16: note: 
>      previous declaration is here
> enum snmp_code snmp_passwd_to_keys(struct snmp_user *, char *);
> /asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:382:1: error: 
>      conflicting types for 'snmp_get_local_keys'
> snmp_get_local_keys(struct snmp_user *user, uint8_t *eid __unused,
> /asp/git/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:274:16: note: 
>      previous declaration is here
> enum snmp_code snmp_get_local_keys(struct snmp_user *, uint8_t *, uint32_t);
> 
> * Second problem is with ldns (used WITHOUT_LDNS as temporary fix)
> ===> lib/libldns (all)
> /usr/local/libexec/ccache/world/clang -target x86_64-unknown-freebsd11.0  -O2 -pipe   -I/asp/git/src/lib/libldns/../../contrib/ldns -DNDEBUG -std=gnu99 -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Qunused-arguments -c /asp/git/src/lib/libldns/../../contrib/ldns/buffer.c -o buffer.o
> In file included from /asp/git/src/lib/libldns/../../contrib/ldns/buffer.c:12:
> In file included from /asp/git/src/lib/libldns/../../contrib/ldns/ldns/ldns.h:98:
> /asp/git/src/lib/libldns/../../contrib/ldns/ldns/dane.h:31:10: fatal error: 
>      'openssl/ssl.h' file not found
> #include <openssl/ssl.h>
> 
> * I found no work-around for this problem so I'm now stuck.
> ===> lib/libc/tests/hash (depend)
> (cd /asp/git/src/lib/libc/tests/hash && make -f /asp/git/src/lib/libc/tests/hash/Makefile _RECURSING_PROGS=  SUBDIR= PROG=h_hash  DEPENDFILE=.depend.h_hash .MAKE.DEPENDFILE=.depend.h_hash   depend)
> (cd /asp/git/src/lib/libc/tests/hash && make -f /asp/git/src/lib/libc/tests/hash/Makefile _RECURSING_PROGS=  SUBDIR= PROG=sha2_test  DEPENDFILE=.depend.sha2_test .MAKE.DEPENDFILE=.depend.sha2_test   depend)
> rm -f .depend.sha2_test
> CC='/usr/local/libexec/ccache/world/clang -target x86_64-unknown-freebsd11.0 ' mkdep -f .depend.sha2_test -a    -I/asp/git/src/lib/libc/tests/hash/../../../../crypto/openssh/openbsd-compat -I/asp/git/src/lib/libc/tests/hash/../../../../crypto/openssh -I/asp/git/src/lib/libnetbsd -I/asp/git/src/contrib/netbsd-tests -DNDEBUG -std=gnu99   /asp/git/src/contrib/netbsd-tests/lib/libc/hash/t_sha2.c
> /asp/git/src/contrib/netbsd-tests/lib/libc/hash/t_sha2.c:45:10: fatal error: 
>      'openssl/sha.h' file not found

Hi,

I fixed 2/3 of the issues in the following commits:

1. https://svnweb.freebsd.org/changeset/base/276319
3. https://svnweb.freebsd.org/changeset/base/276318

ldns needs to be fixed to not define LDNS_BUILD_CONFIG_HAVE_SSL to 1 in common.h and HAVE_SSL in config.h. I didn’t touch it because I don’t maintain that component and the issue isn’t a trivial fix and I can’t test all of the permutations easily. Please file a PR and CC des_at_ on the PR.

Thanks for the report!