On 01/31/14 21:30, Danilo E. Gondolfo wrote: > On 01/31/14 05:16, Hans Petter Selasky wrote: >> On 01/31/14 02:46, Huang Wen Hui wrote: >>> Hi Hans, >>> >>> pos_x[] is not non-inialized, it may be previous pos_x, it is still >>> ok for >>> getting dx. >>> "n" var is trying to reduce "untouch" sensor data for post >>> proccessing. I >>> attach a new patch >>> may be more clear, also fixed unexpected movement when button status or >>> ntouch changing. >>> >>> Cheers, >>> >>> Huang Wen Hui >> >> Hi, >> >> http://svnweb.freebsd.org/changeset/base/261315 >> >> --HPS >> > > Good work! > > I noticed that your driver is based on the Linux driver [1] and some > pieces of code are copied, are you sure that we won't have any problems > with license? > > These changes can be (should be) merged in the driver atp(4), no? > > Danilo. > > > [1] - http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c Hi, It looks to me like some tables have been copied. We probably should add a notice about that. The rest of the code looks OK to me. Huang, any comments? --HPSReceived on Fri Jan 31 2014 - 21:51:00 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:46 UTC