Re: Fix Emulex "oce" driver in CURRENT

From: Luigi Rizzo <rizzo_at_iet.unipi.it>
Date: Mon, 7 Jul 2014 13:23:41 +0200
On Mon, Jul 7, 2014 at 1:03 PM, Borja Marcos <borjam_at_sarenet.es> wrote:
>
> On Jul 1, 2014, at 10:24 PM, Luigi Rizzo wrote:
>
>>
>>
>>
>> On Tue, Jul 1, 2014 at 8:58 PM, <borjam_at_sarenet.es> wrote:
>> El 30.06.2014 18:36, Stefano Garzarella escribió:
>>
>> Hello,
>> I had problems during some experiments with Emulex and "oce" driver in
>> CURRENT.
>> I found several bugs in the "oce" driver and this patch fixes them.
>>
>> At least with some cards, the driver simply does not work. It causes a panic when there is some traffic.
>>
>> The relevant bug report is here.
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183391
>>
>> The latest version available from the Emulex website works. But the version bundled with 9.3 and at least -STABLE (which is the same version bundled with -CURRENT) does cause panics on 10- and 9-
>>
>> i compared the code on the emulex website (10.0.747.0 ?) with the
>> one in HEAD and it does not seem much different, but perhaps
>> you have some other version in mind ?
>>
>> The bugs found by stefano exist also in the emulex version above.
>
> Anyway
>
> The "fixed" version is an instant panic when generating traffic (just use iperf3). Version 10.0.747.0  does _not_ panic.

we'll try to investigate, can you tell us more about the environment you use ?
(FreeBSD version, card model (PCI id perhaps), iperf3 invocation line,
interface configuration etc.)

The main differences between 10.0.747.0 and the code in head (after
our fix) is the use
of drbr_enqueue/dequeue versus the peek/putback in the transmit routine.


Both drivers still have issues when the link flaps because the
transmit queue is not cleaned
up properly (unlike what happens in the linux driver and all FreeBSD
drivers for different
hardware), so it might well be that you are seeing some side effect of
that or other
problem which manifests itself differently depending on the environment.

'instant panic' by itself does not tell us anything about what could
be the problem you experience (and we do not see it with either driver).

cheers
luigi
Received on Mon Jul 07 2014 - 09:23:45 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:50 UTC