Re: Fix Emulex "oce" driver in CURRENT

2014-07-15 12:00 GMT+02:00 Borja Marcos <borjam_at_sarenet.es>:

>
> On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote:
>
> > I just tried to run iperf3 with this patch and STABLE-10 and it seems to
> > work.
> > Do you have a panic?
>
> So far, so good. I've ran a couple of iperf3 tests (60 seconds, trying
> both directions) and it doesn't crash.
>
> Without the fixes I obtained a panic quite reliably, in less than 30
> seconds.


> Still trying. But the bugs you mentioned (lack of locking and
> deallocating, etc) seem to be consistent with the kind of failures I saw
> and their apparent randomness.
>

Well.


>
> So, asking for spiritual counsel now. Would you use this driver  in a
> production environment instead of the 747 version downloaded from Emulex? I
> think the latter is giving slightly better performance but, anyway, I
> disable LRO and TSO because I see a horrible impact on NFS performance.
>
>
I made a diff between the two versions (CURRENT and 747) and I saw that the
main difference is in the management of buf_ring through drbr API.
In the CURRENT driver they use a new function drbr_peek() instead of
drbr_dequeue() and I think this is better.
However, even in the 747 version seems to have the problem of the lack of
locking.

Cheers,
Stefano

Cheers,
>
>
>
>
>
> Borja.
>
>


-- 
Stefano Garzarella