Re: About the type of physaddr in struct usb_page.

From: Hans Petter Selasky <hps_at_selasky.org>
Date: Mon, 02 Jun 2014 09:10:23 +0200
On 06/02/14 03:22, Kohji Okuno wrote:
> Hi HPS,
>
> I think the type of physaddr in struct usb_page is incorrect.
> We shuld use bus_addr_t for physaddr.
> What do you think about this?
>
> 60	 * The following structure defines physical and non kernel virtual
> 61	 * address of a memory page having size USB_PAGE_SIZE.
> 62	 */
> 63	struct usb_page {
> 64	#if USB_HAVE_BUSDMA
> 65	        bus_size_t physaddr;
> 66	        void   *buffer;                 /* non Kernel Virtual Address */
> 67	#endif
> 68	};
>
> Regards,
>   Kohji Okuno

Hi,

http://svnweb.freebsd.org/changeset/base/266969

--HPS
Received on Mon Jun 02 2014 - 05:09:44 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:49 UTC