Re: Recent Changes to WITH_*/WITHOUT_* in src

On May 10, 2014 03:29 PM -0600, Warner Losh wrote:
> 
> On May 10, 2014, at 3:25 PM, Shawn Webb <lattera_at_gmail.com> wrote:
> 
> > On May 10, 2014 02:14 PM -0600, Warner Losh wrote:
> >> 
> >> On May 10, 2014, at 10:45 AM, Shawn Webb <lattera_at_gmail.com> wrote:
> >> 
> >>> Hey All,
> >>> 
> >>> It seems that the recent changes to the makefiles for building
> >>> world/kernel have broken some modifications I have locally for
> >>> implementing ASLR+PIE. I'm quite the bsd make newbie, so I thought I'd
> >>> ask for a bit of help. I'm sure the solution is quite simple.
> >>> 
> >>> My code is up on GitHub. I'll include links at the bottom of the email.
> >>> 
> >>> The code in question is in share/mk/bsd.prog.mk, where I'm checking to
> >>> see if MK_PIE is not equal to "no". Prior to the recent changes, this
> >>> code used to work. (Please note that I know that the way I'm cheking is
> >>> a bit bloated, if anyone has any suggestions to trim my code down, let
> >>> me know).
> >> 
> >> You?ll need to add PIE to DEFAULT_NO_OPTIONS in bsd.opts.mk since
> >> bsd.*.mk files need it.
> >> 
> > 
> > Thanks a lot! Adding it to that one worked.
> > 
> > But what's the difference between the DEFAULT_NO_OPTIONS in src.opts.mk and
> > bsd.opts.mk?
> 
> Options to build FreeBSD?s /usr/src are defined in src.opts.mk. Options tested by bsd.*.mk, which can be used to build other things, are in bsd.opts.mk. 

Cool. Thanks for the clarification. Do the options tested by bsd.opts.mk
get parsed by the ports framework? I've added similar functionality to
the ports framework, but maybe I can remove it in favor of
bsd.opts.mk + bsd.prog.mk?

Thanks,

Shawn