Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

From: Li-Wen Hsu <lwhsu_at_FreeBSD.org>
Date: Mon, 12 May 2014 01:49:23 +0800
On Sat, May 10, 2014 at 20:06:58 -0600, Warner Losh wrote:
> 
> On May 10, 2014, at 8:06 PM, Warner Losh <imp_at_bsdimp.com> wrote:
> 
> > 
> > On May 10, 2014, at 6:27 PM, Craig Rodrigues <rodrigc_at_FreeBSD.org> wrote:
> > 
> >> Warner,
> >> 
> >> It looks like your change broke the FreeBSD-HEAD-modules
> >> build.
> >> 
> >> This build does the following:
> >> 
> >> export JFLAG="-j4"
> >> export MAKESYSPATH="${WORKSPACE}/mk”
> > 
> > Shouldn’t this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be …/share/mk or $TOP/share/mk when building outside of make world-like environments now.
> > 
> > Warner
> > 
> >> cd ${WORKSPACE}/sys/modules
> >> echo "=== make cleandir ==="
> >> make cleandir
> >> echo "=== make depend ==="
> >> make ${JFLAG} depend
> >> echo "=== make all ==="
> >> make ${JFLAG} all
> 
> Just confirmed that it works with a proper MAKESYSPATH…
> 
> Warner
> 

This job checks out svn://svn.freebsd.org/base/head/sys to
${WORKSPACE}/sys and svn://svn.freebsd.org/base/head/share/mk to
${WORKSPACE}/mk , then sets MAKESYSPATH="${WORKSPACE}/mk" since I was
trying not to check out the whole src tree.

Just be curious, why in line 24 of sys/conf/kern.opts.mk , we do:

    .include "../../share/mk/bsd.mkopt.mk"

but not:

    .include <bsd.mkopt.mk>

like other .mk files under sys/conf ?

I tried to switch to this and it seems work, but I am not sure if this
is your original intention.  I'll change the modules building job to
checkout the whole src tree if this is not an accepted solution.

Thanks,
Li-Wen

-- 
Li-Wen Hsu <lwhsu_at_FreeBSD.org>
http://lwhsu.org
Received on Sun May 11 2014 - 15:49:26 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:49 UTC