Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386

On May 11, 2014, at 1:43 PM, Craig Rodrigues <rodrigc_at_FreeBSD.org> wrote:

> Hi,
> 
> No, that's not the problem, because we specifically check out
> /usr/share/mk into $WORKSPACE/mk before running the build.
> 
> The problem is due to this commit:
> 
> http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=265832&r2=265841
> 
> You didn't completely remove MK_FORMAT_EXTENSIONS from this file,

I never tried.

> so we are now getting this error message:
> 
> make[1]: "/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk"
> line 24: Could not find ../../share/mk/bsd.mkopt.mk

We assume a certain tree layout, which your script violates, so we can’t include this file. We simply don’t support building the kernel with such arbitrary system layouts.

We have to include it this way, rather than other ways, because when you are building out of tree you don’t pass in the root.

I don’t think this is a valid test of the build system. You are building with weird tree layouts. Please build with standard layouts.

> make[1]: "/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk"
> line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} == "no”)

Since we can’t include the file, anything downstream from that is just noise and needs to be ignored.

Warner

> --
> Craig
> 
> 
> On Sat, May 10, 2014 at 7:06 PM, Warner Losh <imp_at_bsdimp.com> wrote:
>> 
>> On May 10, 2014, at 6:27 PM, Craig Rodrigues <rodrigc_at_FreeBSD.org> wrote:
>> 
>>> Warner,
>>> 
>>> It looks like your change broke the FreeBSD-HEAD-modules
>>> build.
>>> 
>>> This build does the following:
>>> 
>>> export JFLAG="-j4"
>>> export MAKESYSPATH="${WORKSPACE}/mk"
>> 
>> Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be .../share/mk or $TOP/share/mk when building outside of make world-like environments now.
>> 
>> Warner
>> 
>>> cd ${WORKSPACE}/sys/modules
>>> echo "=== make cleandir ==="
>>> make cleandir
>>> echo "=== make depend ==="
>>> make ${JFLAG} depend
>>> echo "=== make all ==="
>>> make ${JFLAG} all
>>> 
>>> 
>>> Can you look into this?
>>> 
>>> Thanks.
>>> 
>>> --
>>> Craig
>>> 
>>> 
>>> On Fri, May 9, 2014 at 3:39 PM,  <jenkins-admin_at_freebsd.org> wrote:
>>>> See <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes>
>>>> 
>>>> Changes:
>>>> 
>>>> [imp] Introduce kern.opts.mk to hold all the options for kernel module
>>>> builds. Include this in the right places. Make src.opts.mk optional so
>>>> that modules can be built outside of the tree in the ports system.
>>>> 
>>>> PR: 189520
>>>> 
>>>> ------------------------------------------
>>>> Started by upstream project "FreeBSD_HEAD" build number 636
>>>> originally caused by:
>>>> Started by an SCM change
>>>> Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in workspace <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/>
>>>> Updating svn://svn.freebsd.org/base/head/sys at revision '2014-05-09T22:39:09.739 +0000'
>>>> U         conf/kmod.mk
>>>> AU        conf/kern.opts.mk
>>>> U         conf/kern.pre.mk
>>>> At revision 265785
>>>> Updating svn://svn.freebsd.org/base/head/share/mk at revision '2014-05-09T22:39:09.739 +0000'
>>>> U         src.opts.mk
>>>> At revision 265785
>>>> [FreeBSD_HEAD-modules] $ /bin/sh -xe /tmp/hudson6703688508778127870.sh
>>>> + export JFLAG=-j4
>>>> + export MAKESYSPATH=<https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/mk>
>>>> + cd <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules>
>>>> + echo '=== make cleandir ==='
>>>> === make cleandir ===
>>>> + make cleandir
>>>> ===> aac (cleandir)
>>>> make[1]: "<https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac/../../conf/kern.opts.mk"> line 24: Could not find ../../share/mk/bsd.mkopt.mk
>>>> make[1]: Fatal errors encountered -- cannot continue
>>>> make[1]: stopped in <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules/aac>
>>>> *** Error code 1
>>>> 
>>>> Stop.
>>>> make: stopped in <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modules>
>>>> Build step 'Execute shell' marked build as failure
>>