Re: [RFC] remove dead code from link_elf.c

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Thu, 15 May 2014 16:50:03 +0300
On Thu, May 15, 2014 at 03:36:51PM +0200, Oliver Pinter wrote:
> Hi all!
> 
> I found that the SPARSE_MAPPING used only in sys/kern/link_elf.c file,
> and no other place in kernel, nor in generated codes in /usr/obj/...
> 
> op_at_pandora-d opBSD.git> git grep -i SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> 
> I proposed to remove the old/dead codes. Patch attached. Tested on amd64.

I agree that SPARSE_MAPPING could go away.  But your testing is void,
since link_elf.c is practically not used on amd64, which utilizes object
file format for klds.

Received on Thu May 15 2014 - 11:50:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:49 UTC