[patch] Wrong assertion in kern_umtx.c

From: Eric van Gyzen <eric_at_vangyzen.net>
Date: Thu, 13 Nov 2014 12:39:40 -0500
There is a [practically] tautological assertion in kern_umtx.c.  I have
not even compile-tested the following patch.  I'll test it when I have
time.  I'd be grateful if someone beats me to it.

Eric


diff --git a/sys/kern/kern_umtx.c b/sys/kern/kern_umtx.c
index 33fdf71..c6b42c0 100644
--- a/sys/kern/kern_umtx.c
+++ b/sys/kern/kern_umtx.c
_at__at_ -169,7 +169,7 _at__at_ struct umtxq_chain {
 };
 
 #define        UMTXQ_LOCKED_ASSERT(uc)        
mtx_assert(&(uc)->uc_lock, MA_OWNED)
-#define        UMTXQ_BUSY_ASSERT(uc)   KASSERT(&(uc)->uc_busy, ("umtx
chain is not busy"))
+#define        UMTXQ_BUSY_ASSERT(uc)   KASSERT((uc)->uc_busy, ("umtx
chain is not busy"))
 
 /*
  * Don't propagate time-sharing priority, there is a security reason,
Received on Thu Nov 13 2014 - 16:39:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:54 UTC