Re: Possible bug in softfloat

On 28 November 2014 at 10:34, Steve Kargl
<sgk_at_troutmask.apl.washington.edu> wrote:
> In a thread on comp.lang.c, it was pointed out that softfloat
> has a bug and in checking src/lib/libc/softfloat I confimed
> the issue is present in FreeBSD.  What I hae not confirmed
> is whether or not it is possible to hit this bug.  In fact,
> it may only hit arm and mips.  Anyway, here's the patch

So we should just commit this?


-a

>
>
> Index: softfloat/bits64/softfloat-macros
> ===================================================================
> --- softfloat/bits64/softfloat-macros   (revision 275211)
> +++ softfloat/bits64/softfloat-macros   (working copy)
> _at__at_ -157,7 +157,7 _at__at_
>          z0 = a0>>count;
>      }
>      else {
> -        z1 = ( count < 64 ) ? ( a0>>( count & 63 ) ) : 0;
> +        z1 = ( count < 128 ) ? ( a0>>( count & 63 ) ) : 0;
>          z0 = 0;
>      }
>      *z1Ptr = z1;
>
> --
> Steve
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"