Re: Ver 2 of the patch [was: Re: i915 driver update testing]

On 10/08/2014 13:05, Konstantin Belousov wrote:
> On Tue, Oct 07, 2014 at 04:04:54PM -0400, Adam McDougall wrote:
>> On 10/07/2014 14:01, Konstantin Belousov wrote:
>>> On Tue, Oct 07, 2014 at 07:44:19PM +0300, Konstantin Belousov wrote:
>>>> >From the same frame, please do
>>>> p *(struct drm_i915_private *)(dev->private)
> p *(struct drm_i915_private *)(dev->dev_private)
> 
>>>
>>> I probably figured out what is wrong, but it is still interesting to
>>> see this piece of data.
>>>
>>> For everybody who has the issue with blank screen or panic after
>>> the patch:
>>> 1. please try the updated patch,
>>> 	https://www.kib.kiev.ua/kib/drm/i915.2.patch
>>> 2. if you use "kldload i915kms" to test the patch and get the blank
>>>    screen, verify do you get panic or just a black screen.  It is
>>>    expected for sc, not so for vt.  For vt, if you do get blank screen
>>>    and not a panic, do not load i915kms manually and run the X server.
>>>    I am interested if running X server does show proper output.
>>>
>>
>> Backtrace seems the same, I repeated the prior commands:
>> http://www.egr.msu.edu/~mcdouga9/i915-patch2-1.txt
> 
> There are more occurences of the bug I fixed once in patch version 2.
> Also, since pmap changes were committed in modified form, please try
> the updated patch at https://www.kib.kiev.ua/kib/drm/i915.3.patch .
> 

No apparent change:
http://www.egr.msu.edu/~mcdouga9/i915-patch3-1.txt

I made a log of the source operations and compile to be certain I was
using the right patch properly:
http://www.egr.msu.edu/~mcdouga9/20141008-compile.txt

Are any of these an issue in the patch?  Seem unrelated but hopefully
harmless:
diff --git a/sys/dev/md/md.c b/sys/dev/md/md.c
diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c
diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c
diff --git a/sys/kern/uipc_shm.c b/sys/kern/uipc_shm.c
diff --git a/sys/kern/uipc_syscalls.c b/sys/kern/uipc_syscalls.c
diff --git a/sys/vm/default_pager.c b/sys/vm/default_pager.c
diff --git a/sys/vm/device_pager.c b/sys/vm/device_pager.c
diff --git a/sys/vm/phys_pager.c b/sys/vm/phys_pager.c
diff --git a/sys/vm/sg_pager.c b/sys/vm/sg_pager.c
diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c
diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c
diff --git a/sys/vm/vm_glue.c b/sys/vm/vm_glue.c
diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c
diff --git a/sys/vm/vm_pager.c b/sys/vm/vm_pager.c
diff --git a/sys/vm/vm_pager.h b/sys/vm/vm_pager.h
diff --git a/sys/vm/vnode_pager.c b/sys/vm/vnode_pager.c

Thanks.