Re: [patch] syscons/vt keymap: Norwegian country code conflicts with default value

From: Tijl Coosemans <tijl_at_FreeBSD.org>
Date: Mon, 22 Sep 2014 19:28:44 +0200
On Mon, 22 Sep 2014 14:09:54 +0200 Stefan Esser <se_at_freebsd.org> wrote:
> Am 21.09.2014 um 18:39 schrieb Gyrd Thane Lange:
> > Hi,
> > 
> > Recent changes in keymap namning for syscons/vt to use shorter names
> > has exposed a conflict with the value "no" both used as country code
> > for Norway and as a default value indicating that no keymap is set.
> > 
> > The attached patch proposes to use "" (empty string) as default value
> > instead.
> 
> Hi Gyrd,
> 
> thank you for reporting the issue!
> 
> I have just committed a slightly different patch to -CURRENT and plan
> to merge it to 10-STABLE in time for the next BETA.
> 
> You may want to check-out r271958 ...
> 
> 
> The approach I have chosen it to let "NO" continue to stand for "do
> not load any keymap", while "no" is now recognized as equivalent to
> "no.kbd".
> 
> 
> The new semantics of the keymap parameter in rc.conf are:
> 
> 	keymap='' ==> do not load any keymap (unchanged)
> 	keymap=NO ==> do not load any keymap (unchanged)
> 	keymap=no ==> load Norwegian keymap  (new)
> 
> This may still catch people that have edited rc.conf to use "no" in
> the meaning "no keymap" by accident, but I see no other approach that
> better complies with POLA ...

Maybe NONE.  It's already being used in a number of cases.
Received on Mon Sep 22 2014 - 15:28:53 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:52 UTC