Re: Fix for r281680 -- broke i386 world

From: Marcelo Araujo <araujobsdport_at_gmail.com>
Date: Sat, 18 Apr 2015 23:36:05 +0800
Hi,

Saw your patch, why %ju and not %llx as the output shows?

Best,
Head/amd64 _at_ r281689 built OK, but my i386 build failed:

...
--- usr.sbin.all__D ---
--- all_subdir_bluetooth ---
/usr/src/usr.sbin/bluetooth/hccontrol/le.c:236:4: error: format specifies
type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned
long long') [-Werror,-Wformat]
                        rp.le_features);
                        ^~~~~~~~~~~~~~
/usr/src/usr.sbin/bluetooth/hccontrol/le.c:253:49: error: format specifies
type 'unsigned long' but the argument has type 'u_int64_t' (aka 'unsigned
long long') [-Werror,-Wformat]
        printf("LE_STATUS: %d %d %lx\n", e, rp.status, rp.le_status);
                                 ~~~                   ^~~~~~~~~~~~
                                 %llx
2 errors generated.
....


The attached patch allows i386 to build, and I then tested to verify
that amd64 still built.  (I don't have Bluetooth devices, so I
cannot test its operation.)

Peace,
david
--
David H. Wolfskill                              david_at_catwhisker.org
Those who murder in the name of God or prophet are blasphemous cowards.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.
Received on Sat Apr 18 2015 - 13:36:07 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:57 UTC