Re: sysctl -a panic on VIMAGE kernels

From: Kristof Provost <kp_at_FreeBSD.org> Date: Sun, 9 Aug 2015 20:25:56 +0200 · This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:59 UTC

On 2015-08-09 13:36:35 (+0300), Gleb Smirnoff <glebius_at_FreeBSD.org> wrote:
> On Sun, Aug 09, 2015 at 12:28:22PM +0200, Kristof Provost wrote:
> K> The following fixes it for me:
> K> 
> K> diff --git a/sys/netinet/tcp_reass.c b/sys/netinet/tcp_reass.c
> K> index 77d8940..3913ef3 100644
> K> --- a/sys/netinet/tcp_reass.c
> K> +++ b/sys/netinet/tcp_reass.c
> K> _at__at_ -84,7 +84,7 _at__at_ SYSCTL_INT(_net_inet_tcp_reass, OID_AUTO, maxsegments, CTLFLAG_RDTUN,
> K>      "Global maximum number of TCP Segments in Reassembly Queue");
> K> 
> K>  static uma_zone_t tcp_reass_zone;
> K> -SYSCTL_UMA_CUR(_net_inet_tcp_reass, OID_AUTO, cursegments, CTLFLAG_VNET,
> K> +SYSCTL_UMA_CUR(_net_inet_tcp_reass, OID_AUTO, cursegments, 0,
> K>      &tcp_reass_zone,
> K>      "Global number of TCP Segments currently in Reassembly Queue”);
> 
> Right, if a variable isn't virtualized, the CTLFLAG_VNET must be removed.
> 
> Patrick, how is your progress wuth improved reassembly?
> 
Any opposition to me committing the above patch? It'll at least make us
stop panic()ing and I don't think it'll make Patrick's life any harder.

Regards,
Kristof