Re: posix_fallocate(2) && posix_fadvise(2) are somewhat broken

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Tue, 8 Dec 2015 19:42:59 +0200
On Tue, Dec 08, 2015 at 04:52:05PM +0100, Dag-Erling Sm??rgrav wrote:
> Maxim Sobolev <sobomax_at_FreeBSD.org> writes:
> > Hi, while working on some unrelated feature I've noticed that at least
> > those two system calls are not returning proper value (-1) on error.
> > Instead actual errno value is returned from the syscall verbatim,
> > i.e. posix_fadvise() returns 22 on EINVAL.
> 
> That's how syscalls work.

No, this is not how typical syscalls work, but is how the posix_fallocate()
and posix_fadvise() are specified by Posix.  The patch is wrong, see also
r261080 and r288640.
Received on Tue Dec 08 2015 - 16:43:11 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:01 UTC