Re: XOR pt. 2

From: NGie Cooper <yaneurabeya_at_gmail.com>
Date: Fri, 11 Dec 2015 14:49:08 -0800
On Fri, Dec 11, 2015 at 1:19 PM, Don Lewis <truckman_at_freebsd.org> wrote:
> On 11 Dec, Michael McConville wrote:
>> Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR
>> cleanly in the current if-else condition, but I'm not sure whether that
>> was intended. I just wanted to pass this by people in case it was a
>> logical bug.
>
> Yeah, the original code looks incorrect.   If HWCSUM is totally disabled
> and the user requests RXCSUM, then the current code will enable both
> RXCSUM and TXCSUM.

Please file a bug on bugzilla, CC erj, sbruno, and myself (ngie).
Thanks!
-NGie
Received on Fri Dec 11 2015 - 21:49:11 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:01 UTC