Re: 9 stable is in worse shape than current ! Some fixes.

Added cc current_at_ (source of broken commits to stable, most likely)
+ text added below.

"Julian H. Stacey" wrote Wed, 14 Jan 2015 03:10:40 +0100:
> Hi freebsd-stable_at_freebsd.org,
> 
> 9 stable is a lot worse than current to build !
> Suprising as in the old days it used to be the other way, but on
> 2 current boxes here I have very little trouble building, (usually
> just new includes needed), whereas 9 stable is lots of trouble:
> 
> My env.:
> 	9-stable ( .ctm_status src-9 1374, .svn_revision 277102 )
> 	(within a prison with 9.2
> 		FreeBSD 9.2-STABLE FreeBSD 9.2-STABLE #3 r264390:
> 		Sun Apr 13 12:16:37 CEST 2014
> 		:/usr/obj/usr/src/sys/GENERIC  amd64 )
> 	The jail has all ist own binaries, not shared with prison...
> 	& with nothing in /etc/make.conf except 	NO_FSCHG=YES
> 	To ease debugging of include paths after interrupted dependent
> 	makes etc, I did not use a /usr/obj/ (though I do normally).
> 
> Problem 1 - Solved:
>  9-stable default : cc -v # gcc version 4.2.1 
>  11-Current default : cc -v # clang version 3.5.0
>  In both cases my boxes use Unchanged default cc.
>  It seems developers only tested make world & bsd.sys.mk with clang !
> 
>  These errors:
>   ===> lib/libfetch (all) SSL
>         cc1: warnings being treated as errors
>         common.c: In function 'fetch_ssl':
>         common.c:808: warning: unused parameter 'URL'
> 
>   ===> lib/libmagic (all)
>         cc1: warnings being treated as errors
>         /usr/src/lib/libmagic/../../contrib/file/src/apprentice.c:942: warning: 'apprentice_list' defined but not used
> 
>  Can be avoided by applying this emergency patch-out:
> 	---------
> 	*** 9-stable/src//share/mk/bsd.sys.mk  Wed Jan 14 02:02:26 2015
> 	--- new/src/share/mk/bsd.sys.mk  Wed Jan 14 02:03:23 2015
> 	***************
> 	*** 32,38 ****
> 	  CWARNFLAGS+=  -Wsystem-headers
> 	  .if !defined(NO_WERROR) && (${COMPILER_TYPE} != "clang" \
> 	      || !defined(NO_WERROR.clang))
> 	! CWARNFLAGS+=  -Werror
> 	  .endif # !NO_WERROR && (!CLANG || !NO_WERROR.clang)
> 	  .endif # WARNS >= 1
> 	  .if ${WARNS} >= 2
> 	--- 32,38 ----
> 	  CWARNFLAGS+=  -Wsystem-headers
> 	  .if !defined(NO_WERROR) && (${COMPILER_TYPE} != "clang" \
> 	      || !defined(NO_WERROR.clang))
> 	! ### CWARNFLAGS+=      -Werror
> 	  .endif # !NO_WERROR && (!CLANG || !NO_WERROR.clang)
> 	  .endif # WARNS >= 1
> 	  .if ${WARNS} >= 2
> 	***************
> 	*** 97,103 ****
> 	  .endif # CLANG
> 	  .if !defined(NO_WERROR) && (${COMPILER_TYPE} != "clang" \
> 	      || !defined(NO_WERROR.clang))
> 	! CWARNFLAGS+=  -Werror
> 	  .endif # !NO_WERROR && (!CLANG || !NO_WERROR.clang)
> 	  .endif # WFORMAT > 0
> 	  .endif # WFORMAT
> 	--- 97,103 ----
> 	  .endif # CLANG
> 	  .if !defined(NO_WERROR) && (${COMPILER_TYPE} != "clang" \
> 	      || !defined(NO_WERROR.clang))
> 	! ### CWARNFLAGS+=      -Werror
> 	  .endif # !NO_WERROR && (!CLANG || !NO_WERROR.clang)
> 	  .endif # WFORMAT > 0
> 	  .endif # WFORMAT
> 	---------
> 
> 
> Problem 2 - Not Solved
> 	# ===> lib/libarchive (all)
> 	#       /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_hash.h:129:20: error: sha1.h: No such file or directory
> 
> 
> Problem 3 - Not Solved
>  ===> libexec/telnetd
> 	... undefined reference  ...
> 
> 
> Problem 4 - Not Solved - in /etc/src.conf I had to add:
> 
> 	WITHOUT_ATM="YES"               # sbin/atm/atmconfig
> 	WITHOUT_OPENSSL="YES"
> 	WITHOUT_RESCUE="YES"
> 
> 	# WITHOUT_BSNMP="YES"           # lib/libbsnmp/libbsnmp
> 		# No longer need to avoid that, maybe fixed by bsd.sys.mk.diff
> 
> Anyone else see these problems ?  Suggestions ?
> 
> These observations are on a production server I've temporarily
> patched out from active service, but I want to return it soon,
> so unless there's some quick fixes, I'll have to down grade it
> from 9-stable to 9.3-RELEASE, cos I dont care about things like
> atm, but I do need ssl & ssh.

Downgrading from broken 9-stable src/ to 9.3-RELEASE solved everything!

Broken code in bsd.sys.mk relate to 11-current's use of clang V. gcc in 9.
There's other broken in 9-stable too
It is easy to check without rebooting, just 
	mount -t devfs dev /9stable/dev ; chroot /9stable ; cd /usr/src ; make
I've tested this on my current box, re-making a 9.3-RELEASE
I hope commiters try it, & back out broken 9stable commits.
Thanks

Cheers,
Julian
-- 
Julian Stacey, BSD Linux Unix C Sys Eng Consultant Munich http://berklix.com
 Indent previous with "> ".  Interleave reply paragraphs like a play script.
 Send plain text, not quoted-printable, HTML, base64, or multipart/alternative.
		-	-	-	-	-	-	-
 Practice French & support democracy ? Buy on 14 Jan http://www.charliehebdo.fr
 A special print run of 5 million in 16 languages, not just French.
 In Munich on 15th at Haupt Bahn Hof International Presse.