Re: gettimeofday((void *)-1, NULL) implicates core dump on recent FreeBSD 11-CURRENT

From: Oliver Pinter <oliver.pinter_at_hardenedbsd.org>
Date: Thu, 9 Jul 2015 14:26:07 +0200
On 7/9/15, NGie Cooper <yaneurabeya_at_gmail.com> wrote:
> On Thu, Jul 9, 2015 at 1:41 AM, Konstantin Belousov <kostikbel_at_gmail.com>
> wrote:
>> On Thu, Jul 09, 2015 at 08:27:17AM +1000, Peter Jeremy wrote:
>>> I'm not sure if we want to explicitly document the conditions under
>>> which
>>> gettimeofday() (or clock_gettime()) are implemented in userland vs
>>> syscalls
>>> because that is guaranteed to get stale over time.  How about stating
>>> that
>> Of course, we don't.  There is no guarantee that the set of conditions
>> is stable even on the stable branch.
>>
>>> these functions are implemented as syscalls only if the AT_TIMEKEEP
>>> value
>>> reported by "procstat -x" is NULL.
>> Mere presence of AT_TIMEKEEP does not imply the use of the fast path.
>> E.g. the fast path can be disabled dynamically, or timecounter could be
>> changed, or libc might be of the wrong version.  My imagination stops
>> there.
>>
>> IMO the point of this discussion is to note that test suite tests useless
>
> useless -> inapplicable

Btw, I have found this is atf's documantation:
atf_tc_expect_signal(SIGSEGV, "reaseon"), with this, we could mark the
specific test case could "fail" / or expect to coredump.

>
>> things.
>
> things. -> things [for FreeBSD].
>
>> If somebody run the test suite for libc, she would immediately note
>> another failing test for the stack protector, which is similar to the
>> gettimeofday nonsense.
>
> Perhaps, but that's assuming that NetBSD implemented gettimeofday in
> userland, which is doesn't.
>
> I agree that this is less applicable for FreeBSD than NetBSD. Please
> keep in mind that contrib/netbsd-tests came from NetBSD, not FreeBSD.
> Peter Holm and I tried our best to vet out the issues with the test
> suite before integrating it in, but there might be issues due to
> implementation discrepancies between FreeBSD and NetBSD.
>
> Thanks,
> -NGie
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
Received on Thu Jul 09 2015 - 10:26:15 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:58 UTC