Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes

On Thu, Jun 18, 2015 at 01:40:30PM +0300, Gleb Smirnoff wrote:
> 
> On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote:
> K> >   you signed up as tester of urtw(4). I have converted urtw(4)
> K> > and uploaded new patch at:
> K> > 
> K> > https://reviews.freebsd.org/D2655
> K> > 
> K> > Please try, report and update the project page.
> K> > 
> K> > https://wiki.freebsd.org/projects/ifnet/net80211
> K> > 
> K> > Thanks a lot for your help with the project.
> K> 
> K> After bringing interface up I'm getting:
> K> http://i.imgur.com/XhOVJ68.jpg
> 
> I've found the problem and updated the diff. Please test once more.
> 
> Thanks for help! Without you the bug could leak into subversion.

Thank you Gleb.  urtw(4) works fine on amd64.

# dmesg |grep urtw
urtw0: <vendor 0x0bda product 0x8187, class 0/0, rev 2.00/1.00, addr 2> on usbus4
urtw0: unknown RTL8187L type: 0x8000000
urtw0: rtl8187l rf rtl8225u hwrev none

One minor problem, I got an compiler error and this diff below fixes it.

--- D2655.diff.orig	2015-06-22 09:45:48.836385086 +0800
+++ D2655.diff	2015-06-22 09:47:56.121431950 +0800
_at__at_ -10421,14 +10421,6 _at__at_
  	struct urtw_vap *uvp = URTW_VAP(vap);
  	struct ieee80211_node *ni;
  	usb_error_t error = 0;
-_at__at_ -1905,7 +1858,6 _at__at_
- 	default:
- 		break;
- 	}
--fail:
- 	URTW_UNLOCK(sc);
- 	IEEE80211_LOCK(ic);
- 	return (uvp->newstate(vap, nstate, arg));
 _at__at_ -1915,12 +1867,11 _at__at_
  urtw_watchdog(void *arg)
  {

> 
> -- 
> Totus tuus, Glebius.

	Kevin