On 5/14/15 2:23 AM, Garrett Cooper wrote: > On May 14, 2015, at 1:06, Poul-Henning Kamp <phk_at_phk.freebsd.dk> wrote: > >> -------- >> In message <20150514075316.GY37063_at_funkthat.com>, John-Mark Gurney writes: >>> Poul-Henning Kamp wrote this message on Thu, May 14, 2015 at 07:42 +0000: >>>> -------- >>>> In message <20150514072155.GT37063_at_funkthat.com>, John-Mark Gurney writes: >>>> >>>>> Since you apprently missed my original reply, I said that we shouldn't >>>>> abuse BUFSIZ for this work, and that it should be changed in mdXhl.c... >>>> Say what ? >>>> >>>> BUFSIZ is used entirely appropriately in MDXFileChunk(): For reading >>>> a file into an algorithm. >>> In fact, posix-2008 references LINE_MAX because: >> MDXFileChunk() does not read lines, it reads an entire file. > Being pedantic, technically it’s a portion of a file, which can be the whole thing, and it reads it in “sizeof(buffer)” chunks (of which buffer is “hardcoded" to BUFSIZ right now). > Cheers! Shouldn't most of these be using st.st_blksize ? I recall being part of the move to get rid of PAGE_SIZE, perhaps many places should be rid of BUFSIZE as well and BUFSIZE should be something we query the system for. -AlfredReceived on Thu May 14 2015 - 13:01:43 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:57 UTC