Re: libiconv: compile error with gcc-4.9

On May 20, 2015, at 0:09, Adrian Chadd <adrian_at_freebsd.org> wrote:

> Hi,
> 
> I have the following compile error with gcc-4.9. Is there an issue
> with the macro/inline, or is it just dead code?
> 
> --- citrus_prop.So ---
> /usr/local/bin/mips-portbld-freebsd11.0-gcc -isystem
> /home/adrian/work/freebsd/head-embedded/obj-gcc/mips.mips/usr/home/adrian/work/freebsd/head-embedded/src/tmp/usr/include
> -L/home/adrian/work/freebsd/head-embedded/obj-gcc/mips.mips/usr/home/adrian/work/freebsd/head-embedded/src/tmp/usr/lib
> --sysroot=/home/adrian/work/freebsd/head-embedded/obj-gcc/mips.mips/usr/home/adrian/work/freebsd/head-embedded/src/tmp
> -B/usr/local/mips-freebsd/bin/ -fpic -DPIC  -O -pipe -G0 -march=mips32
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/include
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../../include
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/mips -DNLS
> -DSOFTFLOAT -D__DBINTERFACE_PRIVATE
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../../contrib/gdtoa
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../../contrib/libc-vis
> -DINET6 -I/home/adrian/work/freebsd/head-embedded/obj-gcc/mips.mips/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/resolv
> -D_ACL_PRIVATE -DPOSIX_MISTAKE
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../libmd
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../../contrib/jemalloc/include
> -DMALLOC_PRODUCTION
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/../../contrib/tzcode/stdtime
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/stdtime
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/locale
> -DBROKEN_DES -DPORTMAP -DDES_BUILTIN
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/rpc
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/mips/softfloat
> -I/usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/softfloat
> -DSOFTFLOAT_FOR_GCC -DYP -DNS_CACHING -DSYMBOL_VERSIONING -std=gnu99
> -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized
> -Wno-pointer-sign   -c
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c
> -o citrus_prop.So
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:
> In function '_citrus_prop_read_chr':
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:112:16:
> error: variable 'neg' set but not used
> [-Werror=unused-but-set-variable]
>  int base, ch, neg;     \
>                ^
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:142:1:
> note: in expansion of macro '_CITRUS_PROP_READ_INT'
> _CITRUS_PROP_READ_INT(chr, int)
> ^
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:
> In function '_citrus_prop_read_num':
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:112:16:
> error: variable 'neg' set but not used
> [-Werror=unused-but-set-variable]
>  int base, ch, neg;     \
>                ^
> /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/iconv/citrus_prop.c:143:1:
> note: in expansion of macro '_CITRUS_PROP_READ_INT'
> _CITRUS_PROP_READ_INT(num, uint64_t)
> ^

If I remember correctly, we obtained libiconv from netbsd. If so, was this fixed already by upstream?
Thanks!