Re: libc/gen: unused variables

From: Adrian Chadd <adrian_at_freebsd.org>
Date: Wed, 20 May 2015 07:56:29 -0700
On 20 May 2015 at 00:50, Konstantin Belousov <kostikbel_at_gmail.com> wrote:
> On Wed, May 20, 2015 at 12:11:08AM -0700, Adrian Chadd wrote:
>> Hi,
>>
>> here's a patch against -head that eliminates gcc-4.9 complaining about
>> set-but-unused variables. It just comments them out for now - are
>> these okay to eliminate, or is there something else that's
>> broken/missing?
> Of course, the patch as posted must not be committed.

Absolutely. This patch was more like "is this all dead code, or are we
supposed to be checking these fields and we aren't?"

> For dl_init_phdr_info(), it is acceptable to eliminate AT_PHENT case
> and phent local.

Would you like to do the elimination, so I don't mess it up? :)

> I have not looked at the other places.

Thanks though!



-adrian
Received on Wed May 20 2015 - 12:56:29 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:57 UTC