Re: Race VT+X11 on -current

From: Hans Petter Selasky <hps_at_selasky.org>
Date: Thu, 21 May 2015 09:36:05 +0200
On 05/11/15 21:52, Ed Maste wrote:
> On 10 May 2015 at 13:14, Hans Petter Selasky <hps_at_selasky.org> wrote:
>>
>> Your patch is correct from what I can see. Signed modulus can be creepy
>> sometimes! Better if VT_MAXWINDOWS was power of two and we used a bitwise
>> AND.
>
> The patch is correct, although signedness doesn't come into play. The
> unsigned vw_number just wraps to 2^32-1, which is 3 modulo 12.

FYI:

https://svnweb.freebsd.org/changeset/base/283187

--HPS
Received on Thu May 21 2015 - 05:35:23 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:57 UTC